Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement custom Default instance for ModeConfig #1565

Merged
merged 1 commit into from
Nov 15, 2021

Conversation

soareschen
Copy link
Contributor

@soareschen soareschen commented Nov 15, 2021

Description

This is a follow up on #1539 to implement a Default instance for ModeConfig that has default values as described in #1539:

[mode]

[mode.clients]
enabled = true
refresh = true
misbehaviour = true

[mode.connections]
enabled = false

[mode.channels]
enabled = false

[mode.packets]
enabled = true
clear_interval = 100
clear_on_start = true
filter = false
tx_confirmation = true

The use of the new default values are tested in #1521.


For contributor use:

  • Added a changelog entry, using unclog.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

@romac romac merged commit 071f609 into master Nov 15, 2021
@romac romac deleted the soares/default-mode-config branch November 15, 2021 13:36
@adizere adizere mentioned this pull request Nov 15, 2021
7 tasks
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants